Attention is currently required from: Subrata Banik, Paul Menzel, Angel Pons, Nick Vaccaro, Eric Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62837 )
Change subject: soc/intel/common/fast_spi: support caching `ext_bios` in ramstage
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/62837/comment/7b423a65_52f56d68
PS3, Line 248: if (ENV_PAYLOAD_LOADER) {
: mtrr_use_temp_range(ext_bios_base, ext_bios_size, type);
: } else {
potential optimization for the future: if the extended BIOS window is added into the list of memranges below before the MTRR calls in fast_spi_cache_bios_region(), then the MTRR solution only needs to be calculated one time instead of two.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87139a9ed7eb9ed43164a5199aa436dd1219145c
Gerrit-Change-Number: 62837
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 18:09:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment