Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Name of user not set #1003801, Andrey Petrov, Patrick Rudolph, Julian Schroeder.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )
Change subject: src/soc/amd/common/fsp: check FSP binary version.
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/58869/comment/5c89c18e_5639cb0e
PS1, Line 80: struct fsp_info_header *info = (struct fsp_info_header *) (fsp_file + FSP_INFO_HEADER_OFF);
hdr->fsp_revision should have all needed information
ok, an also hdr->revision. but it's all included in hdr which gets passed as an argument to soc_validate_fspm_header
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58869
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf50f16b5e9793d946a95970fcdabc4c07289646
Gerrit-Change-Number: 58869
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1003801
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Name of user not set #1003801
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Comment-Date: Wed, 03 Nov 2021 19:50:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1003801
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment