Attention is currently required from: Marc Jones, Patrick Rudolph, Johnny Lin, Rocky Phagura, Jingle Hsu, Angel Pons, Morgan Jang, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49460 )
Change subject: cpu/x86/smm: Add smm_board_info for SMM that can be set from mainboard
......................................................................
Patch Set 16:
(2 comments)
Patchset:
PS16:
Don't think setting the console level
File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/49460/comment/1d48bb51_71ad8dc5
PS16, Line 65: u32 smm_board_info;
why not add what you need here explicitly: uart and console loglevel, guarded by DEBUG_SMI?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81722a4f1bf75ec942cc06e403ad702dfe938e71
Gerrit-Change-Number: 49460
Gerrit-PatchSet: 16
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 15 Jun 2021 04:44:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment