Attention is currently required from: Henry Sun, Marco Chen.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51288 )
Change subject: mb/google/octopus/var/fleex: Only check LTE sku on fleex
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/51288/comment/14ae6ca4_401205ff
PS1, Line 10: 20
0x20?
whoops, yes. 0x20
https://review.coreboot.org/c/coreboot/+/51288/comment/db36604f_5a16c086
PS1, Line 33: if (!is_lte_sku())
I think we can move the check just into is_lte_sku() since the function name is for all LTE SKU in t […]
okay, I try another one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51288
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f3d5fed4315fc716acad1a07735221d154c377e
Gerrit-Change-Number: 51288
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Comment-Date: Fri, 05 Mar 2021 12:41:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment