Attention is currently required from: Jérémy Compostella, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email )
Change subject: vc/google/chromeos: Add low battery indicator screen ......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/google/chromeos/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86225/comment/8b371d78_52a0c712?usp... : PS1, Line 43: cbfs-files-$(CONFIG_CHROMEOS_LOW_BATTERY_INDICATOR_SCREEN) += low_battery_logo.bmp
This is the second time this code is duplicated. I would suggest to introduce a function.
can you please explain what you mean by `second time this code is duplicated`. this is how we add binaries into CBFS
-
Subrata Banik (Code Review)