Attention is currently required from: Martin Roth, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49582 )
Change subject: nb/intel/ironlake: Split out some QuickPath init code ......................................................................
Patch Set 1:
(9 comments)
File src/northbridge/intel/ironlake/quickpath.c:
https://review.coreboot.org/c/coreboot/+/49582/comment/b90c2282_f576f421 PS1, Line 281: freqs_reversed << 8) | ((u8) (vv.freq_min_reduced * Avoid multiple line dereference - prefer 'vv.freqs_reversed'
https://review.coreboot.org/c/coreboot/+/49582/comment/239119f6_a80bc5e4 PS1, Line 283: freq_min_reduced Avoid multiple line dereference - prefer 'vv.freq_min_reduced'
https://review.coreboot.org/c/coreboot/+/49582/comment/88afcc67_261e0634 PS1, Line 289: divisor_f3_to_f1 Avoid multiple line dereference - prefer 'vv.divisor_f3_to_f1'
https://review.coreboot.org/c/coreboot/+/49582/comment/b4cd9ff3_90d007ca PS1, Line 315: freq4_to_max_remainder Avoid multiple line dereference - prefer 'ratios2.freq4_to_max_remainder'
https://review.coreboot.org/c/coreboot/+/49582/comment/3bc6783c_3eeeea75 PS1, Line 318: divisor_f4_to_fmax Avoid multiple line dereference - prefer 'ratios2.divisor_f4_to_fmax'
https://review.coreboot.org/c/coreboot/+/49582/comment/4e8f382c_f9b8b0fe PS1, Line 459: if (!(deven & 8)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/49582/comment/a53dbdb5_cde1807a PS1, Line 468: pci_read_config8(PCI_DEV (0, 0x2, 0x0), 0x4c); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49582/comment/93c9d1d2_59aefcd4 PS1, Line 469: pci_read_config8(PCI_DEV (0, 0x2, 0x0), 0x4c); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49582/comment/a01e8732_c4050b4b PS1, Line 470: pci_read_config8(PCI_DEV (0, 0x2, 0x0), 0x4e); space prohibited between function name and open parenthesis '('
-
build bot (Jenkins) (Code Review)