Attention is currently required from: Patrick Georgi, Julius Werner.
Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60232 )
Change subject: cbfstool: Avoid defining _XOPEN_SOURCE
......................................................................
Patch Set 3:
(1 comment)
File util/cbfstool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60232/comment/7ca24b4e_55f831cb
PS1, Line 137: ifneq ($(OS_ARCH),$(filter $(OS_ARCH), Darwin FreeBSD))
As long as glibc still builds that way that's fine by me too.
It looks like this is no longer required for glibc. I updated the change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13
Gerrit-Change-Number: 60232
Gerrit-PatchSet: 3
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 22 Dec 2021 02:59:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Alex James
theracermaster@gmail.com
Gerrit-MessageType: comment