Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47692 )
Change subject: ACPI S3: Remove unused acpi_is_wakeup_s4() ......................................................................
ACPI S3: Remove unused acpi_is_wakeup_s4()
Change-Id: Id4728b637c784ee2bff7b175e13f4c10419b7f1b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/x86/acpi_s3.c M src/include/acpi/acpi.h 2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/47692/1
diff --git a/src/arch/x86/acpi_s3.c b/src/arch/x86/acpi_s3.c index e805ca3..af4ab5e 100644 --- a/src/arch/x86/acpi_s3.c +++ b/src/arch/x86/acpi_s3.c @@ -41,11 +41,6 @@ return (acpi_slp_type == ACPI_S3); }
-int acpi_is_wakeup_s4(void) -{ - acpi_handoff_wakeup(); - return (acpi_slp_type == ACPI_S4); -} #endif /* ENV_RAMSTAGE */
#define WAKEUP_BASE 0x600 diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 78740fb..2fc5f8e 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1072,13 +1072,11 @@ #else int acpi_is_wakeup(void); int acpi_is_wakeup_s3(void); -int acpi_is_wakeup_s4(void); #endif
#else static inline int acpi_is_wakeup(void) { return 0; } static inline int acpi_is_wakeup_s3(void) { return 0; } -static inline int acpi_is_wakeup_s4(void) { return 0; } #endif
static inline uintptr_t acpi_align_current(uintptr_t current)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47692 )
Change subject: ACPI S3: Remove unused acpi_is_wakeup_s4() ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47692 )
Change subject: ACPI S3: Remove unused acpi_is_wakeup_s4() ......................................................................
ACPI S3: Remove unused acpi_is_wakeup_s4()
Change-Id: Id4728b637c784ee2bff7b175e13f4c10419b7f1b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47692 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/acpi_s3.c M src/include/acpi/acpi.h 2 files changed, 0 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/arch/x86/acpi_s3.c b/src/arch/x86/acpi_s3.c index e805ca3..af4ab5e 100644 --- a/src/arch/x86/acpi_s3.c +++ b/src/arch/x86/acpi_s3.c @@ -41,11 +41,6 @@ return (acpi_slp_type == ACPI_S3); }
-int acpi_is_wakeup_s4(void) -{ - acpi_handoff_wakeup(); - return (acpi_slp_type == ACPI_S4); -} #endif /* ENV_RAMSTAGE */
#define WAKEUP_BASE 0x600 diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 78740fb..2fc5f8e 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1072,13 +1072,11 @@ #else int acpi_is_wakeup(void); int acpi_is_wakeup_s3(void); -int acpi_is_wakeup_s4(void); #endif
#else static inline int acpi_is_wakeup(void) { return 0; } static inline int acpi_is_wakeup_s3(void) { return 0; } -static inline int acpi_is_wakeup_s4(void) { return 0; } #endif
static inline uintptr_t acpi_align_current(uintptr_t current)
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Kyösti Mälkki (Code Review)