Attention is currently required from: Eric Lai, Ivy Jian, Nick Vaccaro, Paul Menzel, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79102?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox: Fix configuration for TPM
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79102/comment/d4a2329c_37028a8c :
PS6, Line 9: i2c1
Nit: i2c4
https://review.coreboot.org/c/coreboot/+/79102/comment/51e4bba9_0e5c87cb :
PS6, Line 9: GPP_E1
Nit: GPP_E1 -> GPP_E2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79102?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0ecaa6fcfc05c3c2e55f857d7a4e59fe46096bb5
Gerrit-Change-Number: 79102
Gerrit-PatchSet: 6
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 28 Nov 2023 21:41:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment