Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35211
to review the following change.
Change subject: mb/google/octopus: Set sar file name for meep sku ......................................................................
mb/google/octopus: Set sar file name for meep sku
Set meep sar file name by sku number
BUG=b:138261454, b:118782854 BRANCH=octopus TEST=emerge-octopus coreboot, and check wifi_sar-meep.hex
Change-Id: I25aa3080392ce277e537c973088dde569246630e Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/meep/include/variant/sku.h M src/mainboard/google/octopus/variants/meep/variant.c 2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/35211/1
diff --git a/src/mainboard/google/octopus/variants/meep/include/variant/sku.h b/src/mainboard/google/octopus/variants/meep/include/variant/sku.h index 5656d37..41cd490 100644 --- a/src/mainboard/google/octopus/variants/meep/include/variant/sku.h +++ b/src/mainboard/google/octopus/variants/meep/include/variant/sku.h @@ -17,6 +17,9 @@ #define __MAINBOARD_SKU_H__
enum { + SKU_1_MEEP = 1, + SKU_2_MEEP = 2, + SKU_3_MEEP = 3, SKU_33_DORP = 33, /* HDMI */ SKU_34_DORP = 34, /* HDMI+Kblight */ SKU_35_DORP = 35, /* HDMI+TS */ diff --git a/src/mainboard/google/octopus/variants/meep/variant.c b/src/mainboard/google/octopus/variants/meep/variant.c index fc34888..5b924d2 100644 --- a/src/mainboard/google/octopus/variants/meep/variant.c +++ b/src/mainboard/google/octopus/variants/meep/variant.c @@ -25,6 +25,11 @@ uint32_t sku_id = get_board_sku();
switch (sku_id) { + case SKU_1_MEEP: + case SKU_2_MEEP: + case SKU_3_MEEP: + filename = "wifi_sar-meep.hex"; + break; case SKU_49_VORTININJA: case SKU_50_VORTININJA: case SKU_51_VORTININJA:
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35211 )
Change subject: mb/google/octopus: Set sar file name for meep sku ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35211/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35211/1//COMMIT_MSG@14 PS1, Line 14: Cq-Depend: chromium:1768380
Wisley Chen has uploaded a new patch set (#2) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/35211 )
Change subject: mb/google/octopus: Set sar file name for meep sku ......................................................................
mb/google/octopus: Set sar file name for meep sku
Set meep sar file name by sku number
Cq-Depend: chromium:1768380 BUG=b:138261454, b:118782854 BRANCH=octopus TEST=emerge-octopus coreboot, and check wifi_sar-meep.hex
Change-Id: I25aa3080392ce277e537c973088dde569246630e Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/meep/include/variant/sku.h M src/mainboard/google/octopus/variants/meep/variant.c 2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/35211/2
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35211 )
Change subject: mb/google/octopus: Set sar file name for meep sku ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35211/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35211/1//COMMIT_MSG@14 PS1, Line 14:
Cq-Depend: chromium:1768380
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35211 )
Change subject: mb/google/octopus: Set sar file name for meep sku ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35211 )
Change subject: mb/google/octopus: Set sar file name for meep sku ......................................................................
mb/google/octopus: Set sar file name for meep sku
Set meep sar file name by sku number
Cq-Depend: chromium:1768380 BUG=b:138261454, b:118782854 BRANCH=octopus TEST=emerge-octopus coreboot, and check wifi_sar-meep.hex
Change-Id: I25aa3080392ce277e537c973088dde569246630e Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35211 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/meep/include/variant/sku.h M src/mainboard/google/octopus/variants/meep/variant.c 2 files changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/meep/include/variant/sku.h b/src/mainboard/google/octopus/variants/meep/include/variant/sku.h index 5656d37..41cd490 100644 --- a/src/mainboard/google/octopus/variants/meep/include/variant/sku.h +++ b/src/mainboard/google/octopus/variants/meep/include/variant/sku.h @@ -17,6 +17,9 @@ #define __MAINBOARD_SKU_H__
enum { + SKU_1_MEEP = 1, + SKU_2_MEEP = 2, + SKU_3_MEEP = 3, SKU_33_DORP = 33, /* HDMI */ SKU_34_DORP = 34, /* HDMI+Kblight */ SKU_35_DORP = 35, /* HDMI+TS */ diff --git a/src/mainboard/google/octopus/variants/meep/variant.c b/src/mainboard/google/octopus/variants/meep/variant.c index fc34888..5b924d2 100644 --- a/src/mainboard/google/octopus/variants/meep/variant.c +++ b/src/mainboard/google/octopus/variants/meep/variant.c @@ -25,6 +25,11 @@ uint32_t sku_id = get_board_sku();
switch (sku_id) { + case SKU_1_MEEP: + case SKU_2_MEEP: + case SKU_3_MEEP: + filename = "wifi_sar-meep.hex"; + break; case SKU_49_VORTININJA: case SKU_50_VORTININJA: case SKU_51_VORTININJA:
-
Chen Wisley (Code Review) -
Furquan Shaikh (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Wisley Chen (Code Review)