Change in coreboot[master]: coreinfo: Add support for link time optimization

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jacob Garber (Code Review)

9 Jan 2020 9 Jan '20

12:45 a.m.

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

coreinfo: Add support for link time optimization

This introduces a Kconfig option for compiling coreinfo with LTO. This option can be used independently of LTO in libpayload, though will benefit most if that is enabled as well. If both are enabled, the final size of coreinfo.elf is reduced from 125K to 122K.

Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M payloads/coreinfo/Kconfig M payloads/coreinfo/Makefile 2 files changed, 12 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/38293/1

diff --git a/payloads/coreinfo/Kconfig b/payloads/coreinfo/Kconfig index fd4c1b4..5fb17bb 100644 --- a/payloads/coreinfo/Kconfig +++ b/payloads/coreinfo/Kconfig @@ -56,6 +56,13 @@ help The version number of this payload.

+config LTO + bool "Use link time optimization" + default n + help + Compile with link time optimization. This can often decrease the + final binary size, but may increase compilation time. + endmenu

menu "Modules" diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index 34c45d9..6452c00 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -90,9 +90,13 @@ include $(src)/.config real-all: $(TARGET)

+ifeq ($(CONFIG_LTO),y) +CFLAGS += -flto=$(CPUS) -fuse-linker-plugin -fno-fat-lto-objects +endif + $(TARGET): $(src)/.config $(coreinfo_obj)/config.h $(OBJS) libpayload printf " LPCC $(subst $(CURDIR)/,,$(@)) (LINK)\n" - $(LPCC) -o $@ $(OBJS) + $(LPCC) $(CFLAGS) -o $@ $(OBJS) $(OBJCOPY) --only-keep-debug $@ $(TARGET).debug $(OBJCOPY) --strip-debug $@ $(OBJCOPY) --add-gnu-debuglink=$(TARGET).debug $@

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

Paul Menzel (Code Review)

1 Feb 1 Feb

10:57 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 2: Code-Review+1

Paul Menzel (Code Review)

10:59 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 2:

(2 comments)

Did you also test with Clang?

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 61: default n I’d default to yes, as less size is more important for firmware purposes.

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 65: Please mention, if libpayload is then also indirectly built with LTO.

Jacob Garber (Code Review)

11:54 p.m.

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38293

to look at the new patch set (#3).

Change subject: coreinfo: Add support for link time optimization ......................................................................

coreinfo: Add support for link time optimization

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/38293/3

David Hendricks (Code Review)

2 Feb 2 Feb

6:18 a.m.

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 3: Code-Review+2

David Hendricks (Code Review)

6:19 a.m.

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 3: -Code-Review

Angel Pons (Code Review)

12:48 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38293/3/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:

https://review.coreboot.org/c/coreboot/+/38293/3/payloads/coreinfo/Kconfig@6... PS3, Line 60: bool "Use link time optimization" Isn't it experimental?

Jacob Garber (Code Review)

3 Feb 3 Feb

7:19 p.m.

Hello David Hendricks, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38293

to look at the new patch set (#4).

Change subject: coreinfo: Add support for link time optimization ......................................................................

coreinfo: Add support for link time optimization

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/38293/4

Jacob Garber (Code Review)

19 Feb 19 Feb

4:21 a.m.

Hello David Hendricks, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38293

to look at the new patch set (#5).

Change subject: coreinfo: Add support for link time optimization ......................................................................

coreinfo: Add support for link time optimization

Tested in QEMU and on Thinkpad T500.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/38293/5

Patrick Georgi (Code Review)

24 Feb 24 Feb

2:18 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 6:

Since coreinfo had libpayload around, including its config, maybe use LTO if libpayload was built with LTO as well?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Gerrit-Change-Number: 38293 Gerrit-PatchSet: 6 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 24 Feb 2020 14:18:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jacob Garber (Code Review)

28 Apr 28 Apr

6:09 p.m.

Hello build bot (Jenkins), David Hendricks, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38293

to look at the new patch set (#9).

Change subject: coreinfo: Add support for link time optimization ......................................................................

coreinfo: Add support for link time optimization

Tested in QEMU and on Thinkpad T500.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/38293/9

Paul Menzel (Code Review)

7 May 7 May

5:16 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 9: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Gerrit-Change-Number: 38293 Gerrit-PatchSet: 9 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 07 May 2020 17:16:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jacob Garber (Code Review)

8 May 8 May

12:13 a.m.

Hello build bot (Jenkins), Paul Menzel, David Hendricks,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38293

to look at the new patch set (#10).

Change subject: coreinfo: Add support for link time optimization ......................................................................

coreinfo: Add support for link time optimization

Tested in QEMU and on Thinkpad T500.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/38293/10

Jacob Garber (Code Review)

25 Aug 25 Aug

9:01 p.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 11:

(3 comments)

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 61: default n

...

I’d default to yes, as less size is more important for firmware purposes.

For now I think no is a safe default - it can enabled in a custom config if the space is really needed.

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 65:

...

Please mention, if libpayload is then also indirectly built with LTO.

No, this will only change it for coreinfo, libpayload needs to be enabled separately.

https://review.coreboot.org/c/coreboot/+/38293/3/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:

https://review.coreboot.org/c/coreboot/+/38293/3/payloads/coreinfo/Kconfig@6... PS3, Line 60: bool "Use link time optimization"

...

Isn't it experimental?

I tested this in QEMU and hardware, so it should be reasonably safe (it's also turned off by default, so anyone who feels like the extra risk can enable it themselves).

-- To view, visit https://review.coreboot.org/c/coreboot/+/38293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Gerrit-Change-Number: 38293 Gerrit-PatchSet: 11 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 25 Aug 2020 21:01:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:49 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 61: default n

...

For now I think no is a safe default - it can enabled in a custom config if the space is really need […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/38293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Gerrit-Change-Number: 38293 Gerrit-PatchSet: 11 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 25 Aug 2020 21:49:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Jacob Garber jgarber1@ualberta.ca Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

15 Sep 15 Sep

8:10 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 12: Code-Review+1

tested successfully for system76/lemp9. builds fine, boots fine

-- To view, visit https://review.coreboot.org/c/coreboot/+/38293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Gerrit-Change-Number: 38293 Gerrit-PatchSet: 12 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 15 Sep 2020 20:10:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

28 Oct 28 Oct

3:05 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 12: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Gerrit-Change-Number: 38293 Gerrit-PatchSet: 12 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Wed, 28 Oct 2020 15:05:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jacob Garber (Code Review)

29 Oct 29 Oct

1:47 a.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

Patch Set 13:

(2 comments)

Conversation has died down, marking as resolved.

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:

https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 65:

...

No, this will only change it for coreinfo, libpayload needs to be enabled separately.

Done

https://review.coreboot.org/c/coreboot/+/38293/3/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:

https://review.coreboot.org/c/coreboot/+/38293/3/payloads/coreinfo/Kconfig@6... PS3, Line 60: bool "Use link time optimization"

...

I tested this in QEMU and hardware, so it should be reasonably safe (it's also turned off by default […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Gerrit-Change-Number: 38293 Gerrit-PatchSet: 13 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 29 Oct 2020 01:47:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Jacob Garber jgarber1@ualberta.ca Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

2 Nov 2 Nov

10:10 p.m.

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38293 )

Change subject: coreinfo: Add support for link time optimization ......................................................................

coreinfo: Add support for link time optimization

Tested in QEMU and on Thinkpad T500.

Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/38293 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/coreinfo/Kconfig M payloads/coreinfo/Makefile 2 files changed, 14 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve

diff --git a/payloads/coreinfo/Kconfig b/payloads/coreinfo/Kconfig index eafb879..2c1f91c 100644 --- a/payloads/coreinfo/Kconfig +++ b/payloads/coreinfo/Kconfig @@ -42,6 +42,15 @@ help The version number of this payload.

+config LTO + bool "Use link time optimization (LTO)" + default n + help + Compile with link time optimization. This can often decrease the + final binary size, but may increase compilation time. This option + is most effective when LTO is also enabled in libpayload, which + is done separately. + endmenu

menu "Modules" diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index d842b46..cd58f39 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -76,9 +76,13 @@ include $(src)/.config real-all: $(TARGET)

+ifeq ($(CONFIG_LTO),y) +CFLAGS += -flto +endif + $(TARGET): $(src)/.config $(coreinfo_obj)/config.h $(OBJS) libpayload printf " LPCC $(subst $(CURDIR)/,,$(@)) (LINK)\n" - $(LPCC) -o $@ $(OBJS) + $(LPCC) $(CFLAGS) -o $@ $(OBJS) $(OBJCOPY) --only-keep-debug $@ $(TARGET).debug $(OBJCOPY) --strip-debug $@ $(OBJCOPY) --add-gnu-debuglink=$(TARGET).debug $@

-- To view, visit https://review.coreboot.org/c/coreboot/+/38293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6feacdb911b52b946869bff369e03dcf72897c9f Gerrit-Change-Number: 38293 Gerrit-PatchSet: 14 Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: merged

1514

days inactive

1812

days old

coreboot-gerrit@coreboot.org

18 comments

8 participants

tags (0)

participants (8)

Angel Pons (Code Review)
David Hendricks (Code Review)
Jacob Garber (Code Review)
Martin Roth (Code Review)
Michael Niewöhner (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Stefan Reinauer (Code Review)