Attention is currently required from: Eric Lai, Felix Held, Jon Murphy, Karthik Ramasubramanian, Matt DeVillier, Paul Menzel.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75659?usp=email )
Change subject: drivers/usb/pci_xhci: Add two xhci DID for phoenix
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/75659/comment/bed2ea07_dc4cc7db :
PS1, Line 604: PCI_DID_AMD_FAM19H_MODEL70H_XHCI1
15C0 and 15C1 is USB4 I don't know where should I add?
I'm not sure, but let's not worry about those as a part of this issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75659?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib59874948725966b04b54def3f6de463afeda709
Gerrit-Change-Number: 75659
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Jun 2023 17:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment