Attention is currently required from: Bao Zheng, Cliff Huang, Fred Reitberger, Jason Glenesk, Lance Zhao, Raul Rangel, Simon Glass, Tim Wawrzynczak, Zheng Bao.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79174?usp=email )
Change subject: soc/amd/mendocino: Add DBG2 ACPI table
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79174/comment/59ef32e7_58f01b18 :
PS7, Line 7: mendocino
needs updating
File src/soc/amd/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/79174/comment/bac92231_80aa93f4 :
PS7, Line 111: get_uart_for_console
Don't you want to check that the current device is equal to the selected console? The way this is wr […]
it might make more sense to put this in `southbridge_write_acpi_tables()` in `src/soc/amd/common/block/acpi/tables.c` so it's only called once without having to check the index of each UART
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c97a78d1889549421baf0bc1a2e8f959a0f47e2
Gerrit-Change-Number: 79174
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Comment-Date: Tue, 28 Nov 2023 17:09:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment