Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86216?usp=email )
Change subject: soc/amd/common/block/pci: Prevent disabling active bridges
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/pci/pcie_gpp.c:
https://review.coreboot.org/c/coreboot/+/86216/comment/3372a332_a7e2ba14?usp... :
PS1, Line 58: static void pcie_internal_gpp_enable(struct device *dev)
: {
: assert(dev->enabled);
: if (!dev->enabled) {
: /*
: * Cannot hide PPB devices! Must keep them enabled to
: * make sure PCI enumeration runs and avoids resource conflicts.
: */
: dev->enabled = true;
: dev->hidden = true;
: dev->ops = &amd_pcie_disabled_gpp_ops;
: }
: }
there are ways to hide the devices behind the bridges which fsp does; not 100% sure if it's the same […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86216?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97098c860aa6cd6b0b59aa7b1c6f7c239e41983
Gerrit-Change-Number: 86216
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 18 Feb 2025 16:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de