Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32246
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
mb/google/octopus: Disable WLAN prior the entry of S5
ODM reported issues that some systems can't be shutdown to S5 very occasionally. ODM found issue is gone if they remove the WLAN card. So, this change to disable WLAN before system enters S5. This change is validated by ODM and it does help issue.
BUG=b:129377927
Change-Id: Ib8e81022b8c9b63bc75e5cc14121233222da7595 Signed-off-by: Kane Chen kane.chen@intel.com --- M src/mainboard/google/octopus/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/32246/1
diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c index 5326118..3305c02 100644 --- a/src/mainboard/google/octopus/variants/baseboard/gpio.c +++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c @@ -341,6 +341,8 @@ static const struct pad_config sleep_s5_gpio_table[] = { /* BT_DISABLE_L */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_109, 0, DEEP, NONE, Tx0RxDCRx1, SAME), + /* WLAN_DISABLE_L */ + PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 0, DEEP, NONE, Tx0RxDCRx1, SAME), };
const struct pad_config *__weak
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
Patch Set 1:
Is this required even with https://review.coreboot.org/c/coreboot/+/32247 ?
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
Patch Set 1:
Patch Set 1:
Is this required even with https://review.coreboot.org/c/coreboot/+/32247 ?
Hi Furquan,
Yes, based on ODM's data. This is the one which make the issue gone.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG@11 PS1, Line 11: ODM found issue is gone if they remove the WLAN card. Please add a blank line above, or, if it is not a paragraph, put it on the line above.
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG@14 PS1, Line 14: Does this affect the shutdown time?
Hello Chen Wisley, Justin TerAvest, Paul Menzel, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32246
to look at the new patch set (#2).
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
mb/google/octopus: Disable WLAN prior the entry of S5
ODM reported issues that some systems can't be shutdown to S5 very occasionally.
ODM found issue is gone if they remove the WLAN card. So, this change to disable WLAN before system enters S5. This change is validated by ODM and it does help issue.
BUG=b:129377927
Change-Id: Ib8e81022b8c9b63bc75e5cc14121233222da7595 Signed-off-by: Kane Chen kane.chen@intel.com --- M src/mainboard/google/octopus/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/32246/2
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG@11 PS1, Line 11: ODM found issue is gone if they remove the WLAN card.
Please add a blank line above, or, if it is not a paragraph, put it on the line above.
done
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG@14 PS1, Line 14:
Does this affect the shutdown time?
nope
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
mb/google/octopus: Disable WLAN prior the entry of S5
ODM reported issues that some systems can't be shutdown to S5 very occasionally.
ODM found issue is gone if they remove the WLAN card. So, this change to disable WLAN before system enters S5. This change is validated by ODM and it does help issue.
BUG=b:129377927
Change-Id: Ib8e81022b8c9b63bc75e5cc14121233222da7595 Signed-off-by: Kane Chen kane.chen@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32246 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Chen Wisley wisley.chen@quantatw.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Chen Wisley: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c index 5326118..3305c02 100644 --- a/src/mainboard/google/octopus/variants/baseboard/gpio.c +++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c @@ -341,6 +341,8 @@ static const struct pad_config sleep_s5_gpio_table[] = { /* BT_DISABLE_L */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_109, 0, DEEP, NONE, Tx0RxDCRx1, SAME), + /* WLAN_DISABLE_L */ + PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 0, DEEP, NONE, Tx0RxDCRx1, SAME), };
const struct pad_config *__weak
Kane Chen has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5 ......................................................................
-
Chen Wisley (Code Review) -
Furquan Shaikh (Code Review)
-
Kane Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)