Change in coreboot[master]: soc/intel/skl: Drop weak mainboard_silicon_init_params

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41113 )

Change subject: soc/intel/skl: Drop weak mainboard_silicon_init_params
......................................................................

soc/intel/skl: Drop weak mainboard_silicon_init_params

We should not need that.

Change-Id: Icff1d1ce9263c3d391e82e449bb0e82051332582
Signed-off-by: Angel Pons 
---
M src/soc/intel/skylake/chip.c
1 file changed, 0 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/41113/1

diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c
index b24ec4f..ee3973f 100644
--- a/src/soc/intel/skylake/chip.c
+++ b/src/soc/intel/skylake/chip.c
@@ -404,12 +404,6 @@
    soc_irq_settings(params);
 }

-/* Mainboard GPIO Configuration */
-__weak void mainboard_silicon_init_params(FSP_S_CONFIG *params)
-{
-	printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
-}
-
 /* Handle FSP logo params */
 const struct cbmem_entry *soc_load_logo(FSPS_UPD *supd)
 {

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41113 )

Change subject: soc/intel/skl: Drop weak mainboard_silicon_init_params
......................................................................

Patch Set 1:

that would mean, that we need to have empty functions for each board that does not use it, though

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41113 )

Change subject: soc/intel/skl: Drop weak mainboard_silicon_init_params
......................................................................

Abandoned