Attention is currently required from: Alexander Couzens, Angel Pons, Felix Singer, Jan Philipp Groß, Paul Menzel.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151) ......................................................................
Patch Set 9:
(5 comments)
File src/mainboard/lenovo/m900/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74187/comment/778095cf_5b6b69be?usp... : PS8, Line 42: # FSP Configuration
Remove comment, seems superfluous.
Done
File src/mainboard/lenovo/m900/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/74187/comment/3365dc70_466ad06e?usp... : PS8, Line 16: // global NVS and variables
Remove comment, seems superfluous.
Done
https://review.coreboot.org/c/coreboot/+/74187/comment/a72ea643_9e92881f?usp... : PS8, Line 19: // CPU
Remove comment, seems superfluous.
Done
https://review.coreboot.org/c/coreboot/+/74187/comment/a4c93106_83d9071c?usp... : PS8, Line 22: Scope (_SB) { :
`Device (_SB. […]
Done
File src/mainboard/lenovo/m900/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74187/comment/653b7a28_bebf27ac?usp... : PS8, Line 8: /* Configure pads prior to SiliconInit() in case there's any : * dependencies during hardware initialization. */ : g
We usually don't configure GPIOs prior to FSP-S anymore, since various FSPs reconfigured them later […]
Done