Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28073 )
Change subject: mainboard/google/nocturne: turn off cams in D3 ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: In this case, that means the _OFF in power resource will be called when transit into to D3hot state.
That'd be true with this change, but prior to this change having a value in _PR3 means to keep the device on in D3hot. Is there any reason to provide power to the devices outside of D0?
the corresponding object to set the device into a deeper Dx must also be declared, and vice versa.
That just says it needs to be declared, so I could stick in an empty _PS3 but nobody bothers to do that even if it's a stronger fit to the spec requirements.
Again I don't think that statement is true, a value in _PR3 does not mean to keep device power in D3Hot. For your reference, the following code https://chromium.googlesource.com/chromiumos/third_party/kernel/+/stabilize-... did explain that.
May I know what kind of problem you are facing now? The steps in _OFF had not been executed?
-
Lijian Zhao (Code Review)