Attention is currently required from: Boris Mittelberg, Caveh Jalali, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Nick Vaccaro, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78077?usp=email )
Change subject: ec/google: Assume LID open for platforms without VBOOT_LID_SWITCH
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/drallion/chromeos.c:
https://review.coreboot.org/c/coreboot/+/78077/comment/2689f9cc_55773861 :
PS7, Line 77: uint32_t get_lid_switch(void)
Can't you just remove this and rely on the new weak function (bunch of other examples in other boards as well)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78077?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34bfc21329660a4bfd1ffed939b6dfb7e7109204
Gerrit-Change-Number: 78077
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 02 Oct 2023 23:13:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment