build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52630 )
Change subject: mainboard: Add Synology DS918+ ......................................................................
Patch Set 1:
(62 comments)
File src/mainboard/synology/ds918plus/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/da5412e8_c47aead0 PS1, Line 49: PAD_CFG_GPI_APIC_IOS(GPIO_33, DN_20K, DEEP, EDGE_SINGLE, NONE, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/d1fdbdda_0b258091 PS1, Line 54: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/44e9c6d2_8d453e31 PS1, Line 55: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/5195644d_db2c2b71 PS1, Line 56: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_40, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/340061a4_ccf890f9 PS1, Line 57: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_41, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/bd8d99ed_1f94c8aa PS1, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/0c524186_2bd0c106 PS1, Line 59: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/0b5d07af_f00b520d PS1, Line 60: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_44, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART1_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/5c33edc8_0343d346 PS1, Line 61: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/50acdb66_95c1c89d PS1, Line 87: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_DT, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/bd2853ad_dbb4023b PS1, Line 88: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_RSP, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/e9c024a6_81ef9caa PS1, Line 104: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_193, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/c4ff045f_86bf9919 PS1, Line 105: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_194, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/c8993fd6_cf737b1a PS1, Line 106: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_195, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/9c3b5078_50eef9f7 PS1, Line 116: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS0, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/8c3e2400_71b8c012 PS1, Line 117: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS1, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/eabfeb4e_d32668ae PS1, Line 119: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_RXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/214ee42a_5ebc86d0 PS1, Line 120: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_TXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/5ee7a7bd_c24f3743 PS1, Line 121: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_CLK, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/7c7d9526_8576dd53 PS1, Line 123: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_RESET_B, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/38c19aa0_1adf8f4d PS1, Line 128: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_STDBY, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/1a910c3c_6de214da PS1, Line 139: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_81, DN_20K, DEEP, NF2, TxDRxE, ENPD), /* AVS_I2C4_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/17e267c3_ab8b112f PS1, Line 141: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_83, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_DMIC_DATA_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/30ec1c2b_40dbec95 PS1, Line 149: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_91, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_I2S3_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/9b5d0f60_f0490644 PS1, Line 159: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_104, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_CLK */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/fd14e5f7_ee90b9e9 PS1, Line 160: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_105, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/10c86732_d5e4c95e PS1, Line 161: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/d3c8940b_74bc2b32 PS1, Line 162: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_109, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/0976888f_a962faa9 PS1, Line 163: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/4f4e900a_47c1c233 PS1, Line 179: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_124, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/09150300_fdc80e8e PS1, Line 180: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_125, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/b0ac164d_30ccddc3 PS1, Line 181: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_126, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/8289034f_02762e52 PS1, Line 182: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/e0442cb7_753638d7 PS1, Line 183: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_128, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/f30978d7_64fc1fc5 PS1, Line 184: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_129, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/967133f8_f3d6562c PS1, Line 185: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_130, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/4452ab2f_2de38f40 PS1, Line 186: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_131, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/7932f7ec_0aa851e4 PS1, Line 187: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_132, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/3997bc6b_aca2feda PS1, Line 188: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/fe53bc85_7f4a3f20 PS1, Line 189: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_134, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/d493e858_782e3aaa PS1, Line 190: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_135, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/100938ce_5b3cc03e PS1, Line 191: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_136, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/1dfc8cb5_c9d13172 PS1, Line 192: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_137, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/caf63890_bf498b4a PS1, Line 193: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_138, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/b990db20_c3ae8c08 PS1, Line 194: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_139, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/2d45ced1_03e71b76 PS1, Line 205: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ0_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/36c2095c_284e77de PS1, Line 206: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/5ac1d82c_907c5488 PS1, Line 207: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_211, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ2_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/0b0fd0bd_5e367cbf PS1, Line 208: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_212, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ3_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/b437fd8f_c471ecad PS1, Line 218: PAD_CFG_NF_IOSTANDBY_IGNORE(PMU_RESETBUTTON_B, NONE, DEEP, NF1), /* PMU_RSTBTN_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/db57e783_8000a1e9 PS1, Line 223: PAD_CFG_GPO_IOSSTATE_IOSTERM(PMU_WAKE_B, 1, DEEP, UP_20K, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/e71d1f79_050198a8 PS1, Line 266: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_CLKOUT1, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_CLKOUT1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/81b99934_50289d32 PS1, Line 267: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD0, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/6e6ff795_0c471126 PS1, Line 268: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD1, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/d36e9ca7_ea8f9d9e PS1, Line 269: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD2, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/d66ab09c_050ae9df PS1, Line 270: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD3, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/ababde91_1a6c082e PS1, Line 272: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_FRAMEB, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_FRAMEB */ line over 96 characters
File src/mainboard/synology/ds918plus/gpio_early.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/ed3fd6ac_f7459f8d PS1, Line 42: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/45518efd_e39624b8 PS1, Line 60: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/2c4700d0_49e1aa40 PS1, Line 61: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/eb448f8f_590d28eb PS1, Line 62: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117643): https://review.coreboot.org/c/coreboot/+/52630/comment/212f845d_5f9ab3e1 PS1, Line 63: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters