Attention is currently required from: Sridhar Siricilla, Kane Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63169 )
Change subject: soc/intel/common: Update CSE sub partition update ......................................................................
Patch Set 2:
(3 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/63169/comment/bb538a00_e23b2bb3 PS2, Line 3: #include <arch/cpu.h> Unrelated.
https://review.coreboot.org/c/coreboot/+/63169/comment/d67eada5_6513ad0b PS2, Line 786: uint32_t size; : uint32_t start_offset; : uint32_t end_offset; Why not `unsigned int`, `size_t` or `off_t`?
https://review.coreboot.org/c/coreboot/+/63169/comment/9f82abd8_909b8ee6 PS2, Line 804: region_name, (uint32_t)start_offset, (uint32_t)size); Why are these casts needed?