Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56021 )
Change subject: cpu/intel/car/p4: Add x86_64 support
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File src/cpu/intel/car/p4-netburst/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/56021/comment/8372a14e_a9afeffe
PS4, Line 364: #include <cpu/x86/64bit/entry64.inc>
Oddly named, I had to think twice to understand what to expect
in there. It's more `enter64`. `entry16.inc` and `entry32.inc`
both define the entry point after switching the mode.
https://review.coreboot.org/c/coreboot/+/56021/comment/bbcb0d70_2e263b8f
PS4, Line 365:
Please add a similar comment as below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56021
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77516e3cd5f0d3b7442be660c005a65b00454343
Gerrit-Change-Number: 56021
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 02 Jul 2021 19:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment