Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68748 )
Change subject: [WIP] security/tpm: add TPM log format as per 2.0 spec ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: In addition, comments from TPM1.2 format regarding event's `name` field, `num_` and `max_entries` apply here as well.
File src/security/tpm/tpm2_log_serialized.h:
https://review.coreboot.org/c/coreboot/+/68748/comment/792004bd_cdd2fcab PS2, Line 51: uint32_t digest_count; Please add a comment that this is hardcoded to 1 in current version.
File src/security/tpm/tspi/log-tpm2.c:
https://review.coreboot.org/c/coreboot/+/68748/comment/6d02d130_f8654753 PS2, Line 42: static struct tcpa_table *tcpa_cbmem_init(void) This is not TCPA, TCPA was the format for TPM1.2. All references to TCPA should be removed, from all files in this change.