Attention is currently required from: Dtrain Hsu, Eric Lai, Kenny Pan, Nick Vaccaro, Paul Menzel, Shou-Chieh Hsu, Subrata Banik.
Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79764?usp=email )
Change subject: mb/google/nissa/var/craaskov: Implement touchscreen power sequencing
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79764/comment/25795dea_9ebe1fb7 :
PS1, Line 2: rex_chou
Please use Rex Chou. […]
Done
https://review.coreboot.org/c/coreboot/+/79764/comment/34451045_4b7bb869 :
PS1, Line 11: This will allow coreboot
: to detect the presence of i2c touchscreens during ACPI SSDT generation
: (implemented in a subsequent commit).
:
is true?
removed
https://review.coreboot.org/c/coreboot/+/79764/comment/078ca293_78674d65 :
PS1, Line 18: Change-Id: I85f2bee58582c0f56331d20a2984a3079c967be4
: Signed-off-by: rex_chou rex_chou@compal.corp-partner.google.com
:
: Change-Id: I3ca2e2d12a86eaae9e37870a2541c0287e354690
:
Two Change-Id tags?
"Change-Id: I3ca2e2d12a86eaae9e37870a2541c0287e354690" is the correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79764?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ca2e2d12a86eaae9e37870a2541c0287e354690
Gerrit-Change-Number: 79764
Gerrit-PatchSet: 2
Gerrit-Owner: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kenny Pan
kennypan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kenny Pan
kennypan@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Tue, 02 Jan 2024 01:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment