Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 )
Change subject: soc/intel/tigerlake: Update GPIO config
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37427/20//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37427/20//COMMIT_MSG@22
PS20, Line 22: GPE_EN
Ack
i tried to check if toggling the gpio sets the sts bit, it didn't work. I don't see any SCI also generated. trying to manipulate the GPI_GPE_STS directly also doesn't work. After setting the GPI_GPE_STS when i checked back i found its still 0. So kernel maybe clearing it whenever it detects set but its not generating the SCI. Can we debug that in a separate bug? lidopen,lidclose is also not working for me with/without this change.
Also in with the latest version of EDS(same document number) the GPIO_CFG is fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa
Gerrit-Change-Number: 37427
Gerrit-PatchSet: 22
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jan 2020 06:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment