Change in coreboot[master]: mb/google/guybrush: Enable EC SMI handler - coreboot-gerrit

10 Mar 2022


      Attention is currently required from: Raul Rangel, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 )
Change subject: mb/google/guybrush: Enable EC SMI handler
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/ec.c:
https://review.coreboot.org/c/coreboot/+/62599/comment/83d7a54b_5e1c110d 
PS2, Line 35: configure_smi(SMITYPE_ESPI_SMI, SMI_MODE_SMI);
Sorry for more follow-up questions:
Does this mean we were not enabling ESPI SMI in the past? If so, were we not handling the LID_CLOSED event in coreboot/depthcharge?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62599
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52b96b1b7c3c25a8355eaba4e84dbce49451b7f8
Gerrit-Change-Number: 62599
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Comment-Date: Thu, 10 Mar 2022 20:59:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment