Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85820?usp=email )
Change subject: soc/intel/meteorlake: Add doc reference for thunderbolt port number
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/85820/comment/c9b11a03_a5e3903b?usp... :
PS1, Line 17: 0x10
lets mention the root port number in decimal to maintain the parity with the EDS ?
I totally agree. I just did not want to touch the code. I am doing it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85820?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic394aa6795105ff613f30e8aa0ffa45500c6332a
Gerrit-Change-Number: 85820
Gerrit-PatchSet: 1
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 31 Dec 2024 18:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com