Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28024 )
Change subject: mainboard/opencellular/elgon: Add mainboard support ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/Mak... File src/mainboard/opencellular/elgon/Makefile.inc:
https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/Mak... PS5, Line 35: gbcv2.dtb Actually it must be named sff8104-linux.dtb, see soc.c I'll remove the devicetree code from ATF as we don't need it at all, and than we don't need to include it into the CBFS.
https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/gbc... File src/mainboard/opencellular/elgon/gbcv2.dts:
https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/gbc... PS5, Line 195: serial@87e02a000000 I think there are only two UARTs exposed. The other entries could be removed.
https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/vbo... File src/mainboard/opencellular/elgon/vboot.fmd:
https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/vbo... PS5, Line 2: 0x63d4c0 Align to a supported flash protection range. 8 or 4 MiB.
-
Patrick Rudolph (Code Review)