Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 )
Change subject: mb/google/guybrush: Enable EC SMI handler ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/ec.c:
https://review.coreboot.org/c/coreboot/+/62599/comment/908d7e8d_19b89567 PS2, Line 35: configure_smi(SMITYPE_ESPI_SMI, SMI_MODE_SMI);
Sorry for more follow-up questions: […]
Yep, it got overlooked on zork (which was the first eSPI platform). Grunt has it enabled since we used a GEVENT for the SMI.
Depthcharge actually has code to poll the lid state: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/plat...
Depthcharge also has code to disable the SMI if a GBB flag is set: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/plat...
It could be argued that we don't really need the SMI handler, but I think it's useful so we can poke the x86 to see if it's still alive.
If we were concerned about having the LID_HANDLER event enabled, we can always remove it from `MAINBOARD_EC_SMI_EVENTS`.
-
Raul Rangel (Code Review)