build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38838 )
Change subject: cpu: Add initial xeonsp support boilerplate ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38838/7/src/cpu/intel/xeonsp/bootbl... File src/cpu/intel/xeonsp/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38838/7/src/cpu/intel/xeonsp/bootbl... PS7, Line 52: if (CONFIG(BOOTBLOCK_CONSOLE)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/38838/7/src/cpu/intel/xeonsp/includ... File src/cpu/intel/xeonsp/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/38838/7/src/cpu/intel/xeonsp/includ... PS7, Line 17: #define NUM_GPI_STATUS_REGS 0 adding a line without newline at end of file
https://review.coreboot.org/c/coreboot/+/38838/7/src/cpu/intel/xeonsp/postca... File src/cpu/intel/xeonsp/postcar.c:
https://review.coreboot.org/c/coreboot/+/38838/7/src/cpu/intel/xeonsp/postca... PS7, Line 20: void fill_postcar_frame(struct postcar_frame *pcf) { open brace '{' following function definitions go on the next line
-
build bot (Jenkins) (Code Review)