[M] Change in coreboot[master]: [WIP] mb/google/nissa/var/craask: Add support for NVMe GPIOs - coreboot-gerrit

24 Nov 2022


      Attention is currently required from: Tarun Tuli, Kangheui Won, Ren Kuo, Tyler Wang, Eric Lai.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69958 )
Change subject: [WIP] mb/google/nissa/var/craask: Add support for NVMe GPIOs
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/craask/gpio.c:
https://review.coreboot.org/c/coreboot/+/69958/comment/2525366c_a440d287 
PS1, Line 15: GPP_D6
...
GPP_D6 is WWAN_EN for craask,but it's SSD_CLKREQ_ODL for craaskneto/crasskino. […]
It's overriden to SSD_CLKREQ_ODL in fw_config.c. CLKREQ pins don't need to be set in bootblock, only in ramstage.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69958
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76a056cddff2246cfb5bb26ddbdfc333b49d9aaf
Gerrit-Change-Number: 69958
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Tyler Wang tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Reka Norman rekanorman@google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Tyler Wang tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 24 Nov 2022 05:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-MessageType: comment