Change in ...coreboot[master]: arch/x86/smbios.c: Remove duplicated 'processor_upgrade'

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31555

Change subject: arch/x86/smbios.c: Remove duplicated 'processor_upgrade'
......................................................................

arch/x86/smbios.c: Remove duplicated 'processor_upgrade'

Change-Id: I3500a648631c91f3a0812c7e661440743ed6a1e1
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/smbios.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/31555/1

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 1f03bc9..d23b5a0 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -560,7 +560,6 @@
    t->processor_version = smbios_processor_name(t->eos);
    t->processor_family = (res.eax > 0) ? 0x0c : 0x6;
    t->processor_type = 3; /* System Processor */
-	t->processor_upgrade = 0x06;
    t->core_count2 = (res.ebx >> 16) & 0xffff;
    if (core_count2 >= 0xff)
    	t->core_count = 0xff;

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31555 )

Change subject: arch/x86/smbios.c: Remove duplicated 'processor_upgrade'
......................................................................

Patch Set 2: Code-Review+2

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31555

to look at the new patch set (#3).

Change subject: arch/x86/smbios.c: Remove duplicated 'processor_upgrade'
......................................................................

arch/x86/smbios.c: Remove duplicated 'processor_upgrade'

Change-Id: I3500a648631c91f3a0812c7e661440743ed6a1e1
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/smbios.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/31555/3

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31555 )

Change subject: arch/x86/smbios.c: Remove duplicated 'processor_upgrade'
......................................................................

Patch Set 3: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31555 )

Change subject: arch/x86/smbios.c: Remove duplicated 'processor_upgrade'
......................................................................

arch/x86/smbios.c: Remove duplicated 'processor_upgrade'

Change-Id: I3500a648631c91f3a0812c7e661440743ed6a1e1
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/31555
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
---
M src/arch/x86/smbios.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index da25694..fdf8ca1 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -560,7 +560,6 @@
    t->processor_version = smbios_processor_name(t->eos);
    t->processor_family = (res.eax > 0) ? 0x0c : 0x6;
    t->processor_type = 3; /* System Processor */
-	t->processor_upgrade = 0x06;
    t->core_count = (res.ebx >> 16) & 0xff;
    t->l1_cache_handle = 0xffff;
    t->l2_cache_handle = 0xffff;