Attention is currently required from: Subrata Banik.
Paz Zcharya has posted comments on this change by Paz Zcharya. ( https://review.coreboot.org/c/coreboot/+/86566?usp=email )
Change subject: refactor: Consolidate bmp_logo_filename() logic
......................................................................
Patch Set 1:
(1 comment)
File src/lib/bmp_logo.c:
https://review.coreboot.org/c/coreboot/+/86566/comment/a51ea416_6c8dcd3f?usp... :
PS1, Line 37: if (platform_is_low_battery_shutdown_needed())
: logo_name = "low_battery.bmp";
Oh, I see. […]
The only issue is that `platform_is_low_battery_shutdown_needed` is defined in `#include <fsp/api.h>`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86566?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd91af411aff6ccd6f5974a0b6c849794b9a2794
Gerrit-Change-Number: 86566
Gerrit-PatchSet: 1
Gerrit-Owner: Paz Zcharya
pazz@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 02:35:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paz Zcharya
pazz@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com