Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86387?usp=email )
Change subject: mb/starlabs/starlite_adl: Reconfigure the vGPIO's for CNVi BT ......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c:
https://review.coreboot.org/c/coreboot/+/86387/comment/6116709e_31014ccd?usp... : PS4, Line 452: /* CNV_BTEN */ : PAD_CFG_GPO(GPP_VGPIO_0, 1, DEEP), : /* CNV_BT_HOST_WAKEB */ : PAD_NC(GPP_VGPIO_4, NONE), : /* CNV_BT_IF_SELECT */ : PAD_CFG_GPO(GPP_VGPIO_5, 1, DEEP),
These seem to make no difference if they're set or not, but I'm inclined to keep?
SGTM
https://review.coreboot.org/c/coreboot/+/86387/comment/d42948be_be455515?usp... : PS4, Line 475: AD_CFG_NF(GPP_VGPIO_30, NONE, DEEP, NF3), : /* BT_I2S_SYNC */ : PAD_CFG_NF(GPP_VGPIO_31, NONE, DEEP, NF3), : /* BT_I2S_SDO */ : PAD_CFG_NF(GPP_VGPIO_32, NONE, DEEP, NF3), : /* BT_I2S_SDI */ : PAD_CFG_NF(GPP_VGPIO_33, NONE, DEEP, NF3), :
My devices are all happy with them NC - are yours?
yep!