Change in coreboot[master]: src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M

[Srinidhi N Kaushik (Code Review)]

Srinidhi N Kaushik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40899 )

Change subject: src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M
......................................................................

src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M

Due to refactoring of Serial IO code in FSP v3163 onwards we need to
set SerialIoUartDebugMode UPD in FSP-M to SkipInit so that SerialIoUart
initialization is skipped in FSP. This makes sure that SerialIo
initialization in coreboot is not changed by FSP.

BUG=b:155315876
BRANCH=none
TEST=build and boot tglrvp/ripto/volteer and check UART debug logs

Signed-off-by: Srinidhi N Kaushik 
Change-Id: I8ba4b9015fa25a84b6b99419ce4d413c9d9daa44
---
M src/soc/intel/tigerlake/romstage/fsp_params.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/40899/1

diff --git a/src/soc/intel/tigerlake/romstage/fsp_params.c b/src/soc/intel/tigerlake/romstage/fsp_params.c
index b4521e2..108a246 100644
--- a/src/soc/intel/tigerlake/romstage/fsp_params.c
+++ b/src/soc/intel/tigerlake/romstage/fsp_params.c
@@ -82,6 +82,7 @@
    }

m_cfg->SerialIoUartDebugControllerNumber = CONFIG_UART_FOR_CONSOLE;
+	m_cfg->SerialIoUartDebugMode = PchSerialIoSkipInit;

/* ISH */
    dev = pcidev_path_on_root(PCH_DEVFN_ISH);

[Srinidhi N Kaushik (Code Review)]

Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40899 )

Change subject: src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M
......................................................................

Patch Set 1: Code-Review+1

[Dossym Nurmukhanov (Code Review)]

Dossym Nurmukhanov has uploaded a new patch set (#3) to the change originally created by Srinidhi N Kaushik. ( https://review.coreboot.org/c/coreboot/+/40899 )

Change subject: src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M
......................................................................

src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M

Due to refactoring of Serial IO code in FSP v3163 onwards we need to
set SerialIoUartDebugMode UPD in FSP-M to SkipInit so that SerialIoUart
initialization is skipped in FSP. This makes sure that SerialIo
initialization in coreboot is not changed by FSP.

BUG=b:155315876
BRANCH=none
TEST=build and boot tglrvp/ripto/volteer and check UART debug logs

Cq-Depend: chrome-internal:2944102
Cq-Depend: chrome-internal:2939733
Cq-Depend: chrome-internal:2943140
Signed-off-by: Srinidhi N Kaushik 
Change-Id: I8ba4b9015fa25a84b6b99419ce4d413c9d9daa44
---
M src/soc/intel/tigerlake/romstage/fsp_params.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/40899/3

[Dossym Nurmukhanov (Code Review)]

Dossym Nurmukhanov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40899 )

Change subject: src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M
......................................................................

Patch Set 3: Code-Review+2

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40899 )

Change subject: src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M
......................................................................

Patch Set 3: Code-Review+2

[Stefan Reinauer (Code Review)]

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40899 )

Change subject: src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M
......................................................................

src/soc/tigerlake: Update SerialIoDebugMode UPD in FSP-M

Due to refactoring of Serial IO code in FSP v3163 onwards we need to
set SerialIoUartDebugMode UPD in FSP-M to SkipInit so that SerialIoUart
initialization is skipped in FSP. This makes sure that SerialIo
initialization in coreboot is not changed by FSP.

BUG=b:155315876
BRANCH=none
TEST=build and boot tglrvp/ripto/volteer and check UART debug logs

Cq-Depend: chrome-internal:2944102
Cq-Depend: chrome-internal:2939733
Cq-Depend: chrome-internal:2943140
Signed-off-by: Srinidhi N Kaushik 
Change-Id: I8ba4b9015fa25a84b6b99419ce4d413c9d9daa44
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40899
Reviewed-by: Dossym Nurmukhanov 
Reviewed-by: Stefan Reinauer 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/tigerlake/romstage/fsp_params.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Stefan Reinauer: Looks good to me, approved
  Srinidhi N Kaushik: Looks good to me, but someone else must approve
  Dossym Nurmukhanov: Looks good to me, approved

diff --git a/src/soc/intel/tigerlake/romstage/fsp_params.c b/src/soc/intel/tigerlake/romstage/fsp_params.c
index 022cd83..e4f6e82 100644
--- a/src/soc/intel/tigerlake/romstage/fsp_params.c
+++ b/src/soc/intel/tigerlake/romstage/fsp_params.c
@@ -82,6 +82,7 @@
    }

m_cfg->SerialIoUartDebugControllerNumber = CONFIG_UART_FOR_CONSOLE;
+	m_cfg->SerialIoUartDebugMode = PchSerialIoSkipInit;

/* ISH */
    dev = pcidev_path_on_root(PCH_DEVFN_ISH);