[L] Change in coreboot[main]: intel skl mainboards: Move PcieRpEnable option below dt entries

[Felix Singer (Code Review)]

Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Jan Samek, Jonathon Hall, Michał Żygowski, Piotr Król.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79958?usp=email )

Change subject: intel skl mainboards: Move PcieRpEnable option below dt entries
......................................................................

Patch Set 6:

(1 comment)

Patchset:

PS6:
> Uderstood. Isn't it then better to just add the missing dt entries in response to CB:79917 and not duplicate work done there? Or if you really insist on preserving the state, suggesting incorporating the missing device dt entries into CB:79917?

Then how do people review this patch pretending that all devicetrees have been checked? Right... They need to go through all .cb files from that platform and compare the option with the devicetree, which is what I am doing here by moving all matching options from a given platform and at the same time I am making the review for others easier. The review is just trivial then. I could yet provide a command that prints out all files containing this option, so that people can compare their local tree against the list of modified files here.

I don't see where the work is duplicated. I am making sure that all affecting boards stay working and I am making the review quite trivial.
> Or if you really insist on preserving the state, suggesting incorporating the missing device dt entries into CB:79917?

Um, yes.. I do insist on preserving the device states. Otherwise this very likely breaks working configurations?

Both changes are two logically separate changes. One fixes something and prepares devicetrees, the other one switches over to a different interface. Not sure how this could be merged.