Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63495 )
Change subject: mb/google/brya/var/brya0: Change MAX98360 AMP interface to I2S1 ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/brya/variants/brya0/fw_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145865): https://review.coreboot.org/c/coreboot/+/63495/comment/09aea8db_06ef71cb PS1, Line 126: } else if(!fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_I2S))){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145865): https://review.coreboot.org/c/coreboot/+/63495/comment/e687fd86_b10279f7 PS1, Line 126: } else if(!fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_I2S))){ space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145865): https://review.coreboot.org/c/coreboot/+/63495/comment/a10a7406_82ddb2fc PS1, Line 145: gpio_configure_pads(i2s_max98360_enable_pads, ARRAY_SIZE(i2s_max98360_enable_pads)); line over 96 characters