Change in ...coreboot[master]: mb/lenovo/x131e: remove PMH7

[James (Code Review)]

James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31065

Change subject: mb/lenovo/x131e: remove PMH7
......................................................................

mb/lenovo/x131e: remove PMH7

This board does not have PMH7.

Change-Id: I382958f012e5f4445efc76c7f36bbdf460c29be4
Signed-off-by: James Ye 
---
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x131e/devicetree.cb
2 files changed, 1 insertion(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31065/1

diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig
index 2a58020..946b945 100644
--- a/src/mainboard/lenovo/x131e/Kconfig
+++ b/src/mainboard/lenovo/x131e/Kconfig
@@ -7,7 +7,6 @@
    select NORTHBRIDGE_INTEL_SANDYBRIDGE
    select USE_NATIVE_RAMINIT
    select SOUTHBRIDGE_INTEL_C216
-	select EC_LENOVO_PMH7
    select EC_LENOVO_H8
    select NO_UART_ON_SUPERIO
    select BOARD_ROMSIZE_KB_12288
diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb
index ccdff7c..4adc94b 100644
--- a/src/mainboard/lenovo/x131e/devicetree.cb
+++ b/src/mainboard/lenovo/x131e/devicetree.cb
@@ -92,18 +92,12 @@
    		device pci 1d.0 on end # USB2 EHCI #1
    		device pci 1e.0 off end # PCI bridge
    		device pci 1f.0 on # LPC bridge PCI-LPC bridge
-				chip ec/lenovo/pmh7
-					register "backlight_enable" = "0x01"
-					register "dock_event_enable" = "0x00"
-					device pnp ff.1 on end # dummy
-				end
-
    			chip drivers/pc80/tpm
    				device pnp 0c31.0 on end
    			end

chip ec/lenovo/h8
-					device pnp ff.2 on # dummy
+					device pnp ff.1 on # dummy
    					io 0x60 = 0x62
    					io 0x62 = 0x66
    					io 0x64 = 0x1600

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31065 )

Change subject: mb/lenovo/x131e: remove PMH7
......................................................................

Patch Set 1: Code-Review+1

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31065 )

Change subject: mb/lenovo/x131e: remove PMH7
......................................................................

Patch Set 1: Code-Review+1

Please also update the documentation for x131e.

[James (Code Review)]

James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31065 )

Change subject: mb/lenovo/x131e: remove PMH7
......................................................................

Patch Set 1:
> Please also update the documentation for x131e.

Could you point me to where the documentation is?

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31065 )

Change subject: mb/lenovo/x131e: remove PMH7
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31065 )

Change subject: mb/lenovo/x131e: remove PMH7
......................................................................

Patch Set 1:

Just to be sure, isn't this the chip that got integrated
into another one? IIRC, the other IVB ThinkPads don't have
it either, but something with a compatible interface.

[James (Code Review)]

James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31065 )

Change subject: mb/lenovo/x131e: remove PMH7
......................................................................

Patch Set 1:
> Just to be sure, isn't this the chip that got integrated
> into another one? IIRC, the other IVB ThinkPads don't have
> it either, but something with a compatible interface.

I'm not aware of a compatible chip on this board. pmh7tool doesn't show anything useful (all 0xff), and google/stout doesn't have anything like pmh7 either.

This laptop doesn't have many of the features that the regular X/T series ThinkPads do (ultrabay, dock, etc.), since it's based on a significantly different (and cheaper) design.

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31065 )

Change subject: mb/lenovo/x131e: remove PMH7
......................................................................

mb/lenovo/x131e: remove PMH7

This board does not have PMH7.

Change-Id: I382958f012e5f4445efc76c7f36bbdf460c29be4
Signed-off-by: James Ye 
Reviewed-on: https://review.coreboot.org/c/31065
Reviewed-by: Paul Menzel 
Reviewed-by: Patrick Rudolph 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x131e/devicetree.cb
2 files changed, 1 insertion(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig
index f52978f..2f936a9 100644
--- a/src/mainboard/lenovo/x131e/Kconfig
+++ b/src/mainboard/lenovo/x131e/Kconfig
@@ -6,7 +6,6 @@
    select NORTHBRIDGE_INTEL_SANDYBRIDGE
    select USE_NATIVE_RAMINIT
    select SOUTHBRIDGE_INTEL_C216
-	select EC_LENOVO_PMH7
    select EC_LENOVO_H8
    select NO_UART_ON_SUPERIO
    select BOARD_ROMSIZE_KB_12288
diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb
index 589c6c9..21d38f5 100644
--- a/src/mainboard/lenovo/x131e/devicetree.cb
+++ b/src/mainboard/lenovo/x131e/devicetree.cb
@@ -90,18 +90,12 @@
    		device pci 1d.0 on end # USB2 EHCI #1
    		device pci 1e.0 off end # PCI bridge
    		device pci 1f.0 on # LPC bridge PCI-LPC bridge
-				chip ec/lenovo/pmh7
-					register "backlight_enable" = "0x01"
-					register "dock_event_enable" = "0x00"
-					device pnp ff.1 on end # dummy
-				end
-
    			chip drivers/pc80/tpm
    				device pnp 0c31.0 on end
    			end

chip ec/lenovo/h8
-					device pnp ff.2 on # dummy
+					device pnp ff.1 on # dummy
    					io 0x60 = 0x62
    					io 0x62 = 0x66
    					io 0x64 = 0x1600