Attention is currently required from: Eren Peng, Ivan Chen.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82085?usp=email )
Change subject: mb/google/brox/var/greenbayupoc:Add SODIMM settings
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/82085/comment/662dd892_deb81bdf :
PS11, Line 47: select MEMORY_SOLDERDOWN
You do not need to change baseboard configuration, you can just use:
`select MEMORY_SOLDERDOWN if !BOARD_GOOGLE_BOARD_GOOGLE_GREENBAYUPOC`
Then just add `select MEMORY_SODIMM` to `BOARD_GOOGLE_GREENBAYUPOC`. You do not need to touch other boards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82085?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1552cadfa81c48fe561947ded078bcca2e6bc6ad
Gerrit-Change-Number: 82085
Gerrit-PatchSet: 11
Gerrit-Owner: Eren Peng
peng.eren@inventec.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Garen Wu
wu.garen@inventec.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
hsueh.rasheed@inventec.corp-partner.google.com
Gerrit-Attention: Eren Peng
peng.eren@inventec.corp-partner.google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Comment-Date: Fri, 03 May 2024 05:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment