Attention is currently required from: Malik Hsu. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55404 )
Change subject: mb/google/brya/variants/primus: set up gpio ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1: Latest schematics I found was 20210607B, is that accurate?
File src/mainboard/google/brya/variants/primus/gpio.c:
https://review.coreboot.org/c/coreboot/+/55404/comment/90acb3e1_fae2f1d4 PS1, Line 24: What about GPP_C3, GPP_C4 ?
https://review.coreboot.org/c/coreboot/+/55404/comment/19132afd_976f932f PS1, Line 29: /* D6 : SRCCLKREQ1# ==> WWAN_SIM1_DET_ODL */ Isn't this NC?
https://review.coreboot.org/c/coreboot/+/55404/comment/056dec75_f6cd31fb PS1, Line 40: GPP_E10, GPP_E17?
https://review.coreboot.org/c/coreboot/+/55404/comment/069e4821_46772143 PS1, Line 50: GPP_H21?