Attention is currently required from: Martin Roth, Tim Wawrzynczak, Julius Werner, Arthur Heymans, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52788 )
Change subject: soc/intel: Don't select VBOOT_SEPARATE_VERSTAGE
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
Should be fine, but I wanted others to provide their opinion.
Seems okay to me. My understanding is that we use VBOOT_SEPARATE_VERSTAGE in a couple of scenarios:
1. Reducing bootblock size (where the slow boot ROM SPI drivers result in boot time impact).
2. Using the overlapping romstage-verstage in memlayout (RETURN_FROM_VERSTAGE) for limited SRAM capacity.
For x86 platforms being updated here, we boot from memory-mapped boot media. So, there is no concern about bootblock loading or SRAM capacity. The only other reason to use VBOOT_SEPARATE_VERSTAGE here was because of the coreboot restriction on bootblock size. If we no longer have the bootblock size restriction, then it should be okay to drop VBOOT_SEPARATE_VERSTAGE selection for these platforms. I will CR+1 for now to let others take a look.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52788
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e02961183b5bcc37365458a3b10342e5bc2b525
Gerrit-Change-Number: 52788
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 03 May 2021 18:38:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment