Change in coreboot[master]: soc/intel: Remove duplicate call to acpi_wake_source() - coreboot-gerrit

28 Jan 2021


      Attention is currently required from: Martin Roth, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Subrata Banik, Michal Motyl, Kyösti Mälkki, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49880 )
Change subject: soc/intel: Remove duplicate call to acpi_wake_source()
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/acpi/acpi_wake_source.c:
https://review.coreboot.org/c/coreboot/+/49880/comment/e5f7825a_8684e4e5 
PS4, Line 28: 		return;
...
Ah yes you're right. […]
Trying to get a hold of a skylake board for testing these kinds of refactors in the future 😊
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49880
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74fdae63111e3ea09000d888a918ebe70d711801
Gerrit-Change-Number: 49880
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Mariusz Szafrański mariuszx.szafranski@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michal Motyl michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Suresh Bellampalli suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Mariusz Szafrański mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Michal Motyl michalx.motyl@intel.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 28 Jan 2021 22:34:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment