Attention is currently required from: Martin Roth, Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49474 )
Change subject: drivers/intel/fsp2_0: Add support for MP PPI services2 APIs ......................................................................
Patch Set 1:
(9 comments)
File src/drivers/intel/fsp2_0/ppi/mp_service2_ppi.c:
https://review.coreboot.org/c/coreboot/+/49474/comment/4f5cc183_74e8d12c PS1, Line 16: efi_pei_mp_services_ppi *ignored1, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49474/comment/6069a108_c5c8b50a PS1, Line 31: efi_pei_mp_services_ppi *ignored1, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49474/comment/f8166c0b_38ac0a78 PS1, Line 66: efi_pei_mp_services_ppi *ignored1, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49474/comment/4408111e_d1f88abf PS1, Line 85: efi_pei_mp_services_ppi *ignored1, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49474/comment/d96cb398_e32c32d7 PS1, Line 95: if (mp_run_on_all_cpus((void *)procedure, argument)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/49474/comment/98ac95b2_fd44764c PS1, Line 103: efi_pei_mp_services_ppi *ignored1, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49474/comment/a6bf0ee8_a8235fd9 PS1, Line 128: efi_pei_mp_services_ppi *ignored1, efi_uintn_t ignored2, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49474/comment/350802ac_5cf96cc2 PS1, Line 136: efi_pei_mp_services_ppi *ignored1, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49474/comment/8080e4ef_768db4dd PS1, Line 144: efi_pei_mp_services_ppi *ignored1, need consistent spacing around '*' (ctx:WxV)
-
build bot (Jenkins) (Code Review)