Attention is currently required from: Raul Rangel, Martin Roth, Marshall Dawson, Felix Held.
Julian Schroeder has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52909 )
Change subject: src/vendorcode/amd/fsp/cezanne/FspmUpd.h: match amd-fsp
......................................................................
Patch Set 1:
(1 comment)
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52909/comment/84005489_1fbfcf56
PS1, Line 110: sh_oem
Can we drop sh_oem? I don't think it adds any clarity.
The next patches are going to clean this up. This is really just temporary. I'm in the process of plumbing all the USB phy related stuff to AMD FSP (AGESA). Felix already stated that he's not sold on a random 100 byte array ;-). I'm providing this as a stopgap until then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib40c30e18878db5604ed1104e1e876986212e67d
Gerrit-Change-Number: 52909
Gerrit-PatchSet: 1
Gerrit-Owner: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 06 May 2021 17:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-MessageType: comment