Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email )
Change subject: mb/google/rauru: Enable firmware display
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85952/comment/1890e9a1_0993e119?usp... :
PS3, Line 9: Enable mt8196 firmware display support.
Please explain what `mt6373_set_vcn33_3_voltage` is for in the commit message.
OK, I will explain more detail in commit message.
https://review.coreboot.org/c/coreboot/+/85952/comment/95491d94_8f6ff528?usp... :
PS3, Line 12: BUG=b:343351631
Also add b:353464237
OK, I will add it.
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85952/comment/5dee104b_a45fab02?usp... :
PS3, Line 107: else
Add {}
OK, I will fix it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85952?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036
Gerrit-Change-Number: 85952
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 09:40:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com