[S] Change in coreboot[main]: soc/amd/common/block/pci: Prevent disabling active bridges

[Felix Held (Code Review)]

Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune, Patrick Rudolph.

Felix Held has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86216?usp=email )

Change subject: soc/amd/common/block/pci: Prevent disabling active bridges
......................................................................

Patch Set 2:

(2 comments)

File src/soc/amd/common/block/pci/pcie_gpp.c:

https://review.coreboot.org/c/coreboot/+/86216/comment/55caccbd_b150f672?usp... :
PS2, Line 52: dev->enabled ||
is this part of the check necessary? i think that dev_is_active_bridge already checks that, right?

https://review.coreboot.org/c/coreboot/+/86216/comment/12bfbb50_dddbd62e?usp... :
PS2, Line 53: 	if (!dev->enabled && dev_is_active_bridge(dev)) {
can this condition ever evaluate to true? when the first part is true, the second part can't be true, since dev_is_active_bridge returns 0 in the !dev->enabled case and dev is the same. or am i reading this wrong?