Attention is currently required from: Malik Hsu. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59563 )
Change subject: mb/google/brya/variants/primus: update gpios for power consumption ......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
https://review.coreboot.org/c/coreboot/+/59563/comment/7466b9ec_1d6a3612 PS4, Line 46: get_sku_and_set_gpio suggestion: `disable_unused_gpios` ?
https://review.coreboot.org/c/coreboot/+/59563/comment/fcc72142_a94c3a88 PS4, Line 48: int sku = gpio_get(GPP_T2); : : if (sku == 1) nit: as fars as I can tell, this GPIO is just stuffed on boards with the eMMC, so let's avoid the term `SKU` here. can you rename this to `emmc_detected` or similar?