Attention is currently required from: Ben Chuang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59429 )
Change subject: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
Thanks Ben!
File src/drivers/genesyslogic/gl9750/Kconfig:
https://review.coreboot.org/c/coreboot/+/59429/comment/f493e736_3a39d472
PS2, Line 6: regulators (3.3V-to-1.2V) and card power switch.
suggestion: add one more sentence like
```
Enabling this driver will disable L0s support, which will allow the device to
enter the PCIe L1 link state.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59429
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d60cef41baade7457a159d3ce2f8d2e6b66e71c
Gerrit-Change-Number: 59429
Gerrit-PatchSet: 2
Gerrit-Owner: Ben Chuang
benchuanggli@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Greg Tu
greg.tu@genesyslogic.com.tw
Gerrit-CC: HsuanYang Chen
ynop77@gmail.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: Ben Chuang
benchuanggli@gmail.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 22:01:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment