build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 )
Change subject: [WIP]mainboard/lenovo/t410: Add new port ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/coreboot/+/11791/14/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/romstage.c:
https://review.coreboot.org/c/coreboot/+/11791/14/src/mainboard/lenovo/t410/... PS14, Line 140: unsigned i; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/11791/14/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/smihandler.c:
https://review.coreboot.org/c/coreboot/+/11791/14/src/mainboard/lenovo/t410/... PS14, Line 35: switch (smif) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/11791/14/src/mainboard/lenovo/t410/... PS14, Line 38: udelay(250000); long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
https://review.coreboot.org/c/coreboot/+/11791/14/src/mainboard/lenovo/t410/... PS14, Line 71: switch (event) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/11791/14/src/mainboard/lenovo/t410/... PS14, Line 98: switch (data) { switch and case should be at the same indent
-
build bot (Jenkins) (Code Review)