Change in coreboot[master]: arch/x86: Include cbmem region into postcar_frame
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34993 ) Change subject: arch/x86: Include cbmem region into postcar_frame ...................................................................... arch/x86: Include cbmem region into postcar_frame This patch signals to the system that cbmem region also needs to be accounted for as it holds cbmem metadata. Change-Id: Ibd2ded90f4faa5d4996f3aefb4da9083a42e0aa8 Signed-off-by: Subrata Banik <subrata.banik@intel.com> --- M src/arch/x86/include/arch/cpu.h M src/arch/x86/postcar_loader.c 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/34993/1 diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index 075e890..42c8a97 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -300,6 +300,8 @@ struct postcar_frame { uintptr_t stack_top; uintptr_t stack; + uintptr_t cbmem_top; + size_t cbmem_size; uint32_t upper_mask; int max_var_mtrrs; int num_var_mtrrs; diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c index d017260..94fde20 100644 --- a/src/arch/x86/postcar_loader.c +++ b/src/arch/x86/postcar_loader.c @@ -69,6 +69,9 @@ /* Keep track of stack top to calculate size used */ pcf->stack_top = pcf->stack; pcf->stack_top += stack_size; + /* Keep track of cbem top and its size */ + pcf->cbmem_top = (uintptr_t) cbmem_top(); + pcf->cbmem_size = cbmem_overhead_size(); return 0; } @@ -158,6 +161,9 @@ SEG_FINAL); /* Also signal the stack region that was written as well */ prog_segment_loaded(pcf->stack, pcf->stack_top - pcf->stack, SEG_FINAL); + /* Also signal that cbmem region that was written as well */ + prog_segment_loaded(pcf->cbmem_top - pcf->cbmem_size, pcf->cbmem_size, + SEG_FINAL); } static void load_postcar_cbfs(struct prog *prog, struct postcar_frame *pcf) -- To view, visit https://review.coreboot.org/c/coreboot/+/34993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd2ded90f4faa5d4996f3aefb4da9083a42e0aa8 Gerrit-Change-Number: 34993 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> Gerrit-MessageType: newchange
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34993 ) Change subject: arch/x86: Include cbmem region into postcar_frame ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/34993/2/src/arch/x86/include/arch/c... File src/arch/x86/include/arch/cpu.h: https://review.coreboot.org/c/coreboot/+/34993/2/src/arch/x86/include/arch/c... PS2, Line 303: uintptr_t cbmem_top; : size_t cbmem_size; Extending the struct seems unnecessary, just call cbmem_top() and cbmem_overhead_size() where you need it. -- To view, visit https://review.coreboot.org/c/coreboot/+/34993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd2ded90f4faa5d4996f3aefb4da9083a42e0aa8 Gerrit-Change-Number: 34993 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 22 Nov 2019 13:38:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34993?usp=email ) Change subject: arch/x86: Include cbmem region into postcar_frame ...................................................................... Abandoned This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author. -- To view, visit https://review.coreboot.org/c/coreboot/+/34993?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd2ded90f4faa5d4996f3aefb4da9083a42e0aa8 Gerrit-Change-Number: 34993 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-MessageType: abandon
participants (3)
-
Arthur Heymans (Code Review) -
Martin L Roth (Code Review)
-
Subrata Banik (Code Review)